Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 )
Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Thanks for the reviews. Carry +1. http://gerrit.cloudera.org:8080/#/c/10669/1/be/src/runtime/fragment-instance-state.cc File be/src/runtime/fragment-instance-state.cc: http://gerrit.cloudera.org:8080/#/c/10669/1/be/src/runtime/fragment-instance-state.cc@a371 PS1, Line 371: : : > From git blame, it appears to be added in 368115cda. Probably was useful wh It's actually from the following commit which is from 6 years ago: https://github.com/apache/impala/commit/7725f25ff5219fb7440ac92d32802dd4ce3cb8f0 Commit 368115cda just moved it around. So, I feel that it's reasonable to remove this now. http://gerrit.cloudera.org:8080/#/c/10669/1/be/src/runtime/fragment-instance-state.cc@368 PS1, Line 368: if (VLOG_FILE_IS_ON) { > you should just remove that if-stmt now. the VLOG_FILE macro will have the Done -- To view, visit http://gerrit.cloudera.org:8080/10669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0445950385fa6160764feaed9a993fa0e59b242 Gerrit-Change-Number: 10669 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Jun 2018 18:14:40 +0000 Gerrit-HasComments: Yes
