Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/22716 )
Change subject: IMPALA-13011: Support authorization for Calcite in Impala ...................................................................... Patch Set 21: (3 comments) In patch set 21, I added some tests to test_ranger.py to have some test coverage for the feature implemented in this patch. Let me know if there are additional suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/22716/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22716/20//COMMIT_MSG@33 PS20, Line 33: AuthorizationStmtTest#testPrivilegeRequests() > It's a good idea to add some test cases under test_ranger.py. Will try to a Done http://gerrit.cloudera.org:8080/#/c/22716/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java: http://gerrit.cloudera.org:8080/#/c/22716/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@207 PS20, Line 207: FeVi > This is a bug. After IMPALA-14080 (Support LocalFsTable table types in Calc Done http://gerrit.cloudera.org:8080/#/c/22716/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java: http://gerrit.cloudera.org:8080/#/c/22716/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@67 PS20, Line 67: // to register the privilege request, we have to do this for now. We created > I think it would make sense to write it up as a proposal for Calcite and li Sure. I created CALCITE-7152 to keep track of this. -- To view, visit http://gerrit.cloudera.org:8080/22716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a7f7e4dc9a86a2da9e387832e552538e34029c1 Gerrit-Change-Number: 22716 Gerrit-PatchSet: 21 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Aug 2025 21:43:26 +0000 Gerrit-HasComments: Yes
