Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22716 )
Change subject: IMPALA-13011: Support authorization for Calcite in Impala ...................................................................... Patch Set 22: Code-Review+1 (3 comments) Thank you Fang-Yu for addressing my comments. http://gerrit.cloudera.org:8080/#/c/22716/22/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java: http://gerrit.cloudera.org:8080/#/c/22716/22/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@49 PS22, Line 49: public class ImpalaSqlValidatorImpl extends SqlValidatorImpl { nit: Can add some documentation about this class. What this class is about. http://gerrit.cloudera.org:8080/#/c/22716/21/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/22716/21/tests/authorization/test_ranger.py@1425 PS21, Line 1425: with self.create_impala_client(user=ADMIN) as admin_client, \ : self.create_impala_client(user=grantee_user) as non_owner_cli > Thanks for pointing this out Riza! That will be good. Although, I prefer to change them gradually or with as few code changes as possible to not make backporting hard. http://gerrit.cloudera.org:8080/#/c/22716/22/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/22716/22/tests/authorization/test_ranger.py@3621 PS22, Line 3621: class TestRangerWithCalcite(TestRanger): : def test_select_calcite_frontend(self, unique_name): nit: separate with single blank line. -- To view, visit http://gerrit.cloudera.org:8080/22716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a7f7e4dc9a86a2da9e387832e552538e34029c1 Gerrit-Change-Number: 22716 Gerrit-PatchSet: 22 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Tue, 02 Sep 2025 14:20:16 +0000 Gerrit-HasComments: Yes
