Jason Fehr has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23385
Change subject: IMPALA-14401: Deflake/Improve OpenTelemetry Tracing Tests ...................................................................... IMPALA-14401: Deflake/Improve OpenTelemetry Tracing Tests The commit contains the following improvements to the Impala queries as OpenTelemetry traces custom cluster tests: 1. Supporting code for asserting traces was moved to 'tests/util/otel_trace.py'. None of the moved code was modified. This move results in the 'test_otel_trace.py' file containing only tests with supporting code being in 'otel_trace.py' 2. Classes 'TestOtelTraceSelectsDMLs' and 'TestOtelTraceDDLs' contain a total of 11 individual tests that use the 'unique_database' fixture. When this fixture is used in a test, it results in two DDLs being run before the test to drop/create the database and one DDL being run after the test to drop the database. These classes now create a test database once during 'setup_class' and drop it once during 'teardown_class' because creating a new database for each test was unnecessary. This change dropped test execution time from about 97 seconds to about 77 seconds. 3. Each test now has comments describing what the test is asserting. 4. The unnecessary sleep in 'test_query_exec_fail' was removed saving five seconds of test execution time. 5. New test 'test_dml_insert_fail' added. Previously, the situation where an insert DML failed was not tested. The test passed without any changes to backend code. 6. Test 'test_ddl_createtable_fail' is greatly simplified by using a debug action to fail the query instead of multiple parallel queries where one dropped the database the other was inserting into. The simplified setup eliminated test flakiness caused by timing differences. Generated-by: Github Copilot (Claude Sonnet 3.7) Change-Id: I0c3e0075df688c7ae601c6f2e5743f56d6db100e --- M tests/custom_cluster/test_otel_trace.py M tests/util/otel_trace.py 2 files changed, 572 insertions(+), 536 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/23385/1 -- To view, visit http://gerrit.cloudera.org:8080/23385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0c3e0075df688c7ae601c6f2e5743f56d6db100e Gerrit-Change-Number: 23385 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Fehr <[email protected]>
