Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23385 )
Change subject: IMPALA-14401: Deflake/Improve OpenTelemetry Tracing Tests ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/23385/4/tests/util/otel_trace.py File tests/util/otel_trace.py: http://gerrit.cloudera.org:8080/#/c/23385/4/tests/util/otel_trace.py@348 PS4, Line 348: def assert_trace(log_file_path, trace_file_path, trace_file_count, query_id, The first three parameters 'log_file_path', 'trace_file_path', and 'trace_file_count' are new. Previously, this function retrieved those values by calling 'self.build_log_path()', 'self.trace_file_path', and 'self.trace_file_count'. All usage of 'log_file_path' is new. This data is needed to remove the call to 'self.assert_impalad_log_contains()' in the '__find_span_log()' function. http://gerrit.cloudera.org:8080/#/c/23385/4/tests/util/otel_trace.py@567 PS4, Line 567: def __find_span_log(log_file_path, span_name, query_id): This function has been modified to remove its dependency on 'self.assert_impalad_log_contains()'. -- To view, visit http://gerrit.cloudera.org:8080/23385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c3e0075df688c7ae601c6f2e5743f56d6db100e Gerrit-Change-Number: 23385 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 08 Sep 2025 23:03:11 +0000 Gerrit-HasComments: Yes
