Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23385 )
Change subject: IMPALA-14401: Deflake/Improve OpenTelemetry Tracing Tests ...................................................................... Patch Set 7: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/23385/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23385/7//COMMIT_MSG@54 PS7, Line 54: is nit: in http://gerrit.cloudera.org:8080/#/c/23385/7/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/23385/7/tests/common/custom_cluster_test_suite.py@729 PS7, Line 729: query_id_from_ui_retry Maybe embed this retry mechanism into the existing query_profile_from_ui instead? http://gerrit.cloudera.org:8080/#/c/23385/4/tests/custom_cluster/test_otel_trace.py File tests/custom_cluster/test_otel_trace.py: http://gerrit.cloudera.org:8080/#/c/23385/4/tests/custom_cluster/test_otel_trace.py@547 PS4, Line 547: def test_retry_select_failed(self): > This is a known issue, but I only ever saw it during the QueryExecution spa Ack http://gerrit.cloudera.org:8080/#/c/23385/4/tests/custom_cluster/test_otel_trace.py@691 PS4, Line 691: def test_ddl_createtable_fail(self, vector, unique_name): > I'm puzzled by this one. I was unable to replicate the issue. The 'parse_ Ack http://gerrit.cloudera.org:8080/#/c/23385/4/tests/util/otel_trace.py File tests/util/otel_trace.py: http://gerrit.cloudera.org:8080/#/c/23385/4/tests/util/otel_trace.py@588 PS4, Line 588: return span_log.group(2), span_log.group(1) : > Added logging to output the log file being read. That will be very helpful Ack -- To view, visit http://gerrit.cloudera.org:8080/23385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c3e0075df688c7ae601c6f2e5743f56d6db100e Gerrit-Change-Number: 23385 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 11 Sep 2025 15:20:20 +0000 Gerrit-HasComments: Yes
