Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23385 )
Change subject: IMPALA-14401: Deflake/Improve OpenTelemetry Tracing Tests ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/23385/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23385/7//COMMIT_MSG@54 PS7, Line 54: is > nit: in Done http://gerrit.cloudera.org:8080/#/c/23385/7/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/23385/7/tests/common/custom_cluster_test_suite.py@729 PS7, Line 729: query_id_from_ui_retry > Maybe embed this retry mechanism into the existing query_profile_from_ui in Done. That is a much better approach since the `query_id_from_ui()` function is only used in otel trace testing. -- To view, visit http://gerrit.cloudera.org:8080/23385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c3e0075df688c7ae601c6f2e5743f56d6db100e Gerrit-Change-Number: 23385 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 11 Sep 2025 20:04:51 +0000 Gerrit-HasComments: Yes
