Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23385 )
Change subject: IMPALA-14401: Deflake/Improve OpenTelemetry Tracing Tests ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/23385/4/tests/custom_cluster/test_otel_trace.py File tests/custom_cluster/test_otel_trace.py: http://gerrit.cloudera.org:8080/#/c/23385/4/tests/custom_cluster/test_otel_trace.py@547 PS4, Line 547: def test_retry_select_failed(self): This test seems flaky in my machine. Can you please loop it and see if you hit it as well? custom_cluster/test_otel_trace.py:579: in test_retry_select_failed self.assert_trace( custom_cluster/test_otel_trace.py:54: in assert_trace assert_trace(self.build_log_path("impalad", "INFO"), self.trace_file_path, util/otel_trace.py:461: in assert_trace __assert_close_attrs(trace.child_spans, root_span_id, query_id, span_err_msg, util/otel_trace.py:771: in __assert_close_attrs __assert_span_events(close_span, expected_events) util/otel_trace.py:624: in __assert_span_events assert len(expected_events) == len(span.events), "Span '{}' expected to have " \ E AssertionError: Span 'ca45c056b4666c09:a883e7ce00000000 - Close' expected to have exactly 2 events, actual: 3 http://gerrit.cloudera.org:8080/#/c/23385/4/tests/custom_cluster/test_otel_trace.py@691 PS4, Line 691: def test_ddl_createtable_fail(self, vector, unique_name): This flaky to me when loop it by itself. Can you try loop it in your machine? impala-py.test -k test_ddl_createtable_fail --exploration=exhaustive custom_cluster/test_otel_trace.py TestOtelTraceDDLs.test_ddl_createtable_fail["table_format: text/none" | "protocol: hs2" | "async_ddl: True" | "exec_option: {'abort_on_error': 1, 'batch_size': 0, 'disable_codegen': False, 'disab le_codegen_rows_threshold': 0, 'exec_single_node_rows_threshold': 0, 'num_nodes': 0, 'test_replan': 1}"] custom_cluster/test_otel_trace.py:701: in test_ddl_createtable_fail self.assert_trace( custom_cluster/test_otel_trace.py:54: in assert_trace assert_trace(self.build_log_path("impalad", "INFO"), self.trace_file_path, util/otel_trace.py:352: in assert_trace session_id = parse_session_id(query_profile) util/query_profile_util.py:31: in parse_session_id match = re.search(r'\n\s+Session ID:\s+(.*)\n', profile_text) ../toolchain/toolchain-packages-gcc10.4.0/python-3.8.18/lib/python3.8/re.py:201: in search return _compile(pattern, flags).search(string) E TypeError: expected string or bytes-like object http://gerrit.cloudera.org:8080/#/c/23385/4/tests/util/otel_trace.py File tests/util/otel_trace.py: http://gerrit.cloudera.org:8080/#/c/23385/4/tests/util/otel_trace.py@588 PS4, Line 588: raise Exception("Exceeded maximum retries to find span log entry for span '{}' " : "and query '{}'".format(span_name, query_id)) nit: It can be helpful to print few last lines of log_file_path before raising this exception. Might save time when investigating jenkins output. -- To view, visit http://gerrit.cloudera.org:8080/23385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c3e0075df688c7ae601c6f2e5743f56d6db100e Gerrit-Change-Number: 23385 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 09 Sep 2025 00:55:47 +0000 Gerrit-HasComments: Yes
