Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23385 )
Change subject: IMPALA-14401: Deflake/Improve OpenTelemetry Tracing Tests ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23385/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23385/2//COMMIT_MSG@22 PS2, Line 22: These classes now create a test database once during 'setup_class' : and drop it once during 'teardown_class' because creating a new : database for each test was unnecessary. This change dropped test : execution time from about 97 seconds to about 77 seconds. Consider do this in the TestOtelTraceBase instead of on each individual test classes. CustomClusterTest already has convoluted setup_class and teardown_class. Please double check that there is no flakiness from overriding them. http://gerrit.cloudera.org:8080/#/c/23385/2/tests/util/otel_trace.py File tests/util/otel_trace.py: http://gerrit.cloudera.org:8080/#/c/23385/2/tests/util/otel_trace.py@353 PS2, Line 353: class TestOtelTrace(CustomClusterTestSuite): So far, all CustomClusterTest implementations are put in either authorization/ or custom_cluster/. I think it it unnecessary to move this class to test/util/. test/util/ should just contains utility functions to help the actual test classes. I would suggest renaming this to TestOtelTraceBase and move it back to test_otel_trace.py. See example of other Test*Base: git grep 'Test.*Base' tests/custom_cluster/ Lets contain everything about Otel testing under test_otel_trace.py. -- To view, visit http://gerrit.cloudera.org:8080/23385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c3e0075df688c7ae601c6f2e5743f56d6db100e Gerrit-Change-Number: 23385 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 08 Sep 2025 15:11:36 +0000 Gerrit-HasComments: Yes
