Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23443 )
Change subject: IMPALA-13472: Patch breakpad to fix minidump stacks for 64KB pages ...................................................................... Patch Set 1: To my best understanding, 2 things happen here: + We round the pointer to whole pages, so we look up the starting address in FindMapping (which should not make a difference), and we also copy whole memory pages. + We maximize the copy to 32k to avoid overly large stack traces. I do not understand from the code or the git log why we need whole pages, but wouldn't setting the upper limit to kStackToCapture = max(32 * 1024, page_size), to ensure that we still copy whole pages, make more sense? (Because that is what the code appears to be doing, although there is no reasoning given for it). -- To view, visit http://gerrit.cloudera.org:8080/23443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf19523e69628e78071636292b3cf464a7b626b8 Gerrit-Change-Number: 23443 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 22 Sep 2025 11:44:05 +0000 Gerrit-HasComments: No
