Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23443 )
Change subject: IMPALA-13472: Patch breakpad to fix minidump stacks for 64KB pages ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23443/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23443/1//COMMIT_MSG@31 PS1, Line 31: It is unclear why Breakpad moves the stack pointer to the bottom According to https://chromium.googlesource.com/breakpad/breakpad/+/master/docs/getting_started_with_breakpad.md, the minidump format may have originated on Windows, and Windows doesn't have the 128 byte red zone according to https://en.wikipedia.org/wiki/Red_zone_(computing). -- To view, visit http://gerrit.cloudera.org:8080/23443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf19523e69628e78071636292b3cf464a7b626b8 Gerrit-Change-Number: 23443 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 22 Sep 2025 22:52:07 +0000 Gerrit-HasComments: Yes
