Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23318 )
Change subject: IMPALA-14105: Calcite planner: Runtime filters not being applied with outer joins ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23318/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java: http://gerrit.cloudera.org:8080/#/c/23318/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@492 PS2, Line 492: joinOp == JoinOperator.FULL_OUTER_JOIN)) { > For Full Outer Join, the Analyzer has a separate method to register the tup If I remember correctly while coding this, I did run into that "line 2" so this code works fine as/is. I also just tested to see if there were any regressions in tpcds if I removed the "FULL_OUTER_JOIN" from both "if" clauses. There were no regressions. Are you saying your preference is to take out the FULL_OUTER_JOIN from the "if" and never call the register? I'm ok with that, it seems fine. My only slight concern, I suppose is that as/is, the inner code is meant to handle this, so we should call it and let the inner code decide. But I can go either way on this. -- To view, visit http://gerrit.cloudera.org:8080/23318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e06d3f35a10f35ff8b57ba25dbab1bc6a35238a Gerrit-Change-Number: 23318 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 22 Sep 2025 18:25:08 +0000 Gerrit-HasComments: Yes
