Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23318 )
Change subject: IMPALA-14105: Calcite planner: Runtime filters not being applied with outer joins ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/23318/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java: http://gerrit.cloudera.org:8080/#/c/23318/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@492 PS2, Line 492: List<TableRef> lhsTableRefs = getTableRefs(joinNode.getChild(0)); > It was easy to just remove it from the caller. Done -- To view, visit http://gerrit.cloudera.org:8080/23318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e06d3f35a10f35ff8b57ba25dbab1bc6a35238a Gerrit-Change-Number: 23318 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sun, 28 Sep 2025 16:59:55 +0000 Gerrit-HasComments: Yes
