Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10702 )
Change subject: IMPALA-7161: Fix impala-config.sh's handling of JAVA_HOME ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10702/2/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/10702/2/bin/impala-config.sh@238 PS2, Line 238: SYSTEM_JAVA_HOME=$(readlink -f /usr/bin/javac | sed "s:bin/javac::") How about using "which javac" and "JAVA_HOME=$(which javac|xargs readlink -f|xargs dirname|xargs dirname)"? It will work for javac not in /usr/bin as well. -- To view, visit http://gerrit.cloudera.org:8080/10702 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf3521b4f44fdbdc841a90fd00c477c9423a75bb Gerrit-Change-Number: 10702 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Jun 2018 01:01:43 +0000 Gerrit-HasComments: Yes
