Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10702 )
Change subject: IMPALA-7161: Fix impala-config.sh's handling of JAVA_HOME ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/10702/2/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/10702/2/bin/impala-config.sh@230 PS2, Line 230: # bin/impala-config-local.sh to set JAVA_HOME, so it is important to pick up that > We could remove this from bootstrap_development as part of this change. I think I'm going to punt on this. I can think of arguments in both directions. http://gerrit.cloudera.org:8080/#/c/10702/2/bin/impala-config.sh@238 PS2, Line 238: SYSTEM_JAVA_HOME=$(readlink -f /usr/bin/javac | sed "s:bin/javac::") > I think Tianyi is right here in that we should honor the javac that's on th Makes sense, done. I'm keeping the assumption that javac is under $JAVA_HOME/bin/. That should be safe. http://gerrit.cloudera.org:8080/#/c/10702/2/bin/impala-config.sh@238 PS2, Line 238: SYSTEM_JAVA_HOME=$(readlink -f /usr/bin/javac | sed "s:bin/javac::") > How about using "which javac" and "JAVA_HOME=$(which javac|xargs readlink - Switched to use "which javac" http://gerrit.cloudera.org:8080/#/c/10702/2/bin/impala-config.sh@241 PS2, Line 241: # Prefer the JAVA_HOME set in the environment, but use the system's JAVA_HOME otherwise > If you don't mind, could you remove the following line in this change. Done -- To view, visit http://gerrit.cloudera.org:8080/10702 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf3521b4f44fdbdc841a90fd00c477c9423a75bb Gerrit-Change-Number: 10702 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Jun 2018 17:42:34 +0000 Gerrit-HasComments: Yes
