Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 )
Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition ...................................................................... Patch Set 1: Code-Review+1 (3 comments) I also had some trouble understanding what this so called "default" partition means, so I'm very happy about this work. Had minor comments, but LGTM. http://gerrit.cloudera.org:8080/#/c/10711/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java: http://gerrit.cloudera.org:8080/#/c/10711/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java@a115 PS1, Line 115: In the old code we had this assert. Don't we need an assert in the new code to check that newHdfsTable has a prototype partition? http://gerrit.cloudera.org:8080/#/c/10711/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java@215 PS1, Line 215: HdfsPartition part = (HdfsPartition)Iterables.getFirst(hdfsTable.getPartitions(), null); nit: too long line http://gerrit.cloudera.org:8080/#/c/10711/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java@216 PS1, Line 216: ;; nit: double ; -- To view, visit http://gerrit.cloudera.org:8080/10711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15e91b50eb7c2a5e0bac8c33d603d6cd8cbaca2e Gerrit-Change-Number: 10711 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Jun 2018 12:58:04 +0000 Gerrit-HasComments: Yes
