Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 )
Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/10711/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10711/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@755 PS2, Line 755: creates the default partition nit: this comment needs updating http://gerrit.cloudera.org:8080/#/c/10711/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@763 PS2, Line 763: setPrototypePartition(msTbl.getSd()); I'm just wondering if we can call the setPrototypePartition() in the constructor for HdfsTable to have the nwly introduced member initialized from the very beginning. -- To view, visit http://gerrit.cloudera.org:8080/10711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15e91b50eb7c2a5e0bac8c33d603d6cd8cbaca2e Gerrit-Change-Number: 10711 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Jun 2018 12:19:27 +0000 Gerrit-HasComments: Yes
