Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/23855 )
Change subject: IMPALA-14563: Provide AnalysisException when aggregating complex type ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/23855/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23855/1//COMMIT_MSG@18 PS1, Line 18: Instead of IllegalStateException, we should instead throw the appropriate nit: Instead of throwing an IllegalStateException, we should throw the appropriate... http://gerrit.cloudera.org:8080/#/c/23855/1//COMMIT_MSG@24 PS1, Line 24: him nit: them or rephrase it to eliminate the need of him http://gerrit.cloudera.org:8080/#/c/23855/1//COMMIT_MSG@25 PS1, Line 25: specifiying typo: specifying http://gerrit.cloudera.org:8080/#/c/23855/1//COMMIT_MSG@30 PS1, Line 30: AnalyzeStmsTest nit: AnalyzeStmtsTest http://gerrit.cloudera.org:8080/#/c/23855/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/23855/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@1165 PS1, Line 1165: groupingExprsCopy_.get(i) It could be extracted as a variable, as it's used multiple times. http://gerrit.cloudera.org:8080/#/c/23855/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@1168 PS1, Line 1168: cannot be used -- To view, visit http://gerrit.cloudera.org:8080/23855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie431873efe7100e8150e93be2aa016381d687268 Gerrit-Change-Number: 23855 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 12 Jan 2026 14:01:54 +0000 Gerrit-HasComments: Yes
