Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23855 )
Change subject: IMPALA-14563: Throw AnalysisException when aggregating complex type ...................................................................... Patch Set 3: (4 comments) I have corrected the changes accordingly. Hope this fixes it. Thank you for the comments. http://gerrit.cloudera.org:8080/#/c/23855/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23855/2//COMMIT_MSG@9 PS2, Line 9: Before this change, when the user tries to aggregate by a complex type, : we threw an IllegalStateException. : : SELECT complex_col, count(*) FROM table_example GROUP BY complex_col; : : Error: : : java.lang.IllegalStateException: null > nit: This commit message will become part of git history, therefore "curren Done http://gerrit.cloudera.org:8080/#/c/23855/2//COMMIT_MSG@18 PS2, Line 18: t the query's p > nit: "we now throw" - this is the change achieved by the commit, this will Done http://gerrit.cloudera.org:8080/#/c/23855/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/23855/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@1167 PS2, Line 1167: + "field: " + expr.toSql()); > I think this comment is redundant here. Done http://gerrit.cloudera.org:8080/#/c/23855/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/23855/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@3006 PS2, Line 3006: cannot be u > 'cannot be used' Done -- To view, visit http://gerrit.cloudera.org:8080/23855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie431873efe7100e8150e93be2aa016381d687268 Gerrit-Change-Number: 23855 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 23 Jan 2026 14:55:59 +0000 Gerrit-HasComments: Yes
