Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23852 )
Change subject: IMPALA-14661: Optimize admissiond memory usage by compressing exec requests ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/23852/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23852/2//COMMIT_MSG@13 PS2, Line 13: compressing TQueryExecRequest > Is it possible to do this based on a size threshold of TQueryExecRequest? T Updated. Let SerializeToSidecar() handle compression when the size exceeds the threshold. Removed admission_control_rpc_compress and use admission_control_rpc_compress_threshold_bytes to control whether compression is enabled. http://gerrit.cloudera.org:8080/#/c/23852/2//COMMIT_MSG@17 PS2, Line 17: bytes. A > nit: startup Done http://gerrit.cloudera.org:8080/#/c/23852/2//COMMIT_MSG@25 PS2, Line 25: : > Should this be: avoid decompressing multiple times? Done http://gerrit.cloudera.org:8080/#/c/23852/2//COMMIT_MSG@26 PS2, Line 26: : Compressed requests are decompressed > Maybe we should consider only doing this if admission queue is empty or adm Do you mean avoiding decompression at submission? Some submission paths currently require TQueryExecRequest, like https://github.com/apache/impala/blob/420e357b9586b45fbf4d08265fa57dd616989377/be/src/scheduling/admission-controller.cc#L1615. Not sure if we can skip decompression at submission, at least it would require additional changes. For now, I keep the existing behavior as more as possible, but we can revisit conditional decompression later -- To view, visit http://gerrit.cloudera.org:8080/23852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a676d1a806451cbf84b0a3f8a706d7c6655e12d Gerrit-Change-Number: 23852 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 13 Jan 2026 13:50:22 +0000 Gerrit-HasComments: Yes
