Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/23852 )
Change subject: IMPALA-14661: Optimize admissiond memory usage by compressing exec requests ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/23852/3/be/src/rpc/sidecar-util.h File be/src/rpc/sidecar-util.h: http://gerrit.cloudera.org:8080/#/c/23852/3/be/src/rpc/sidecar-util.h@60 PS3, Line 60: return Status::OK(); > We can't free buf here. The buf is managed by serializer_'s internal TMemor I think calling SerializeToBuffer on the same buffer twice should be fine? http://gerrit.cloudera.org:8080/#/c/23852/5/be/src/rpc/thrift-util.h File be/src/rpc/thrift-util.h: http://gerrit.cloudera.org:8080/#/c/23852/5/be/src/rpc/thrift-util.h@285 PS5, Line 285: // Prepare compressor. : boost::scoped_ptr<Codec> compressor; : Codec::CodecInfo codec_info(THdfsCompression::LZ4); : RETURN_IF_ERROR(Codec::CreateCompressor(nullptr, false, codec_info, &compressor)); 'compressor' and similarly 'decompressor' could be cached to avoid creating them for every request. http://gerrit.cloudera.org:8080/#/c/23852/5/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/23852/5/be/src/scheduling/admission-control-service.cc@158 PS5, Line 158: bool compressed = false; : if (req->has_is_compressed()) { : compressed = req->is_compressed(); : } : if (compressed) { Maybe directly check if (req->has_is_compressed()) since you're not accessing the bool 'compressed' again. http://gerrit.cloudera.org:8080/#/c/23852/5/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/23852/5/be/src/scheduling/admission-controller.h@568 PS5, Line 568: UpdateAdminssionRequestCompressionStats typo: UpdateAdmission -- To view, visit http://gerrit.cloudera.org:8080/23852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a676d1a806451cbf84b0a3f8a706d7c6655e12d Gerrit-Change-Number: 23852 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 15 Jan 2026 21:27:32 +0000 Gerrit-HasComments: Yes
