Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23864 )
Change subject: IMPALA-14680: Improve row regex search syntax in runtime profile tests ...................................................................... Patch Set 1: (11 comments) http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/hdfs_parquet_scan_node_profile.test File testdata/workloads/functional-query/queries/QueryTest/hdfs_parquet_scan_node_profile.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/hdfs_parquet_scan_node_profile.test@5 PS1, Line 5: (?:\[[^]]+\])? Why is this part needed? http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/hdfs_scanner_profile.test File testdata/workloads/functional-query/queries/QueryTest/hdfs_scanner_profile.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/hdfs_scanner_profile.test@5 PS1, Line 5: total maybe this remained from the aggregated profile patch? http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-basic.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-basic.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-basic.test@13 PS1, Line 13: row_regex: total-planning-duration: nit: extra whitespace http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-with-deletes.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-with-deletes.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-with-deletes.test@26 PS1, Line 26: Iceberg Plan Metrics for Node 03: The change seems to remove several lines from the expected output - what is the reason for this? http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test File testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test@12 PS1, Line 12: total is the "total" really there in this patch? http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/joins_mt_dop.test File testdata/workloads/functional-query/queries/QueryTest/joins_mt_dop.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/joins_mt_dop.test@13 PS1, Line 13: total= total http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/kudu_insert_mem_limit.test File testdata/workloads/functional-query/queries/QueryTest/kudu_insert_mem_limit.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/kudu_insert_mem_limit.test@9 PS1, Line 9: (?:\[[^]]+\])? ? http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test File testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test@47 PS1, Line 47: ?: Is this needed because of the search vs match change? http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/processing-cost-admission-slots.test File testdata/workloads/functional-query/queries/QueryTest/processing-cost-admission-slots.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/processing-cost-admission-slots.test@35 PS1, Line 35: UNAGGREGATED Spillover from aggregated profile change? http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test File testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test@146 PS1, Line 146: UNAGGREGATED ? http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/union-const-scalar-expr-codegen.test File testdata/workloads/functional-query/queries/QueryTest/union-const-scalar-expr-codegen.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/union-const-scalar-expr-codegen.test@17 PS1, Line 17: #UNION_NODE Why did the output change? -- To view, visit http://gerrit.cloudera.org:8080/23864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1460c2d22b03c06aa43c85f78fa9e05cec2775ec Gerrit-Change-Number: 23864 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 14 Jan 2026 15:46:45 +0000 Gerrit-HasComments: Yes
