Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23864 )
Change subject: IMPALA-14680: Improve row regex search syntax in runtime profile tests ...................................................................... Patch Set 2: (8 comments) I am sorry for letting these mistakes slip through. Thank you very much for noting them. I have corrected the test changes now. http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/hdfs_parquet_scan_node_profile.test File testdata/workloads/functional-query/queries/QueryTest/hdfs_parquet_scan_node_profile.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/hdfs_parquet_scan_node_profile.test@5 PS1, Line 5: : PARQUET/SNAP > Why is this part needed? This remained from the aggregated profile change. Fixed. Thank you. http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/hdfs_scanner_profile.test File testdata/workloads/functional-query/queries/QueryTest/hdfs_scanner_profile.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/hdfs_scanner_profile.test@5 PS1, Line 5: 11.00 > maybe this remained from the aggregated profile patch? Fixed. http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-basic.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-basic.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-basic.test@13 PS1, Line 13: row_regex: total-planning-duration: > nit: extra whitespace Done http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-with-deletes.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-with-deletes.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-with-deletes.test@26 PS1, Line 26: Iceberg Plan Metrics for Node 03: > The change seems to remove several lines from the expected output - what is They were removed as the lines being matched were not unique. If really required, they can indeed be kept by making these matches unique. In this case, I believe it might be redundant to do it. http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test File testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test@12 PS1, Line 12: 7 \(7 > is the "total" really there in this patch? Done. Fixed. Thanks. http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/joins_mt_dop.test File testdata/workloads/functional-query/queries/QueryTest/joins_mt_dop.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/joins_mt_dop.test@13 PS1, Line 13: 22 \(2 > total Done http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test File testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test@47 PS1, Line 47: ?: > Is this needed because of the search vs match change? Yes, due to this, non-capturing groups are being used in row_regex. http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/union-const-scalar-expr-codegen.test File testdata/workloads/functional-query/queries/QueryTest/union-const-scalar-expr-codegen.test: http://gerrit.cloudera.org:8080/#/c/23864/1/testdata/workloads/functional-query/queries/QueryTest/union-const-scalar-expr-codegen.test@17 PS1, Line 17: #UNION_NODE > Why did the output change? This is spill over from aggregated profile change. The same text was trying to be matched multiple times.(i.e. Codegen Enabled), hence repeated lines were removed. Similar to one of the previous test I had mentioned. This output match can be reinstated by making the it unique similarly. While posting this now in the relation with 'Enabled Aggregated Profile' change I will use "ExecOptions(?:\[[^]]+\])" to fix this there. -- To view, visit http://gerrit.cloudera.org:8080/23864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1460c2d22b03c06aa43c85f78fa9e05cec2775ec Gerrit-Change-Number: 23864 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 14 Jan 2026 18:40:05 +0000 Gerrit-HasComments: Yes
