Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/23237 )
Change subject: IMPALA-14285: Add SAML2 authentication support for Coordinator Web UI ...................................................................... Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/23237/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23237/11//COMMIT_MSG@7 PS11, Line 7: Coordi > Would this work for other components than coordinator? If not than it could Experimentally it doesn't work correctly for neither catalogd nor executors. Changing the code to disregard the flags for non-coordinators. http://gerrit.cloudera.org:8080/#/c/23237/11/be/src/rpc/authentication-util.cc File be/src/rpc/authentication-util.cc: http://gerrit.cloudera.org:8080/#/c/23237/11/be/src/rpc/authentication-util.cc@300 PS11, Line 300: Status status = Ex > It seems clear to me to use and return a unique_ptr<TWrappedHttpResponse>. Good idea, ack. http://gerrit.cloudera.org:8080/#/c/23237/11/be/src/rpc/authentication-util.cc@307 PS11, Line 307: > Same as line 300 ack http://gerrit.cloudera.org:8080/#/c/23237/11/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/23237/11/be/src/util/backend-gflag-util.cc@173 PS11, Line 173: saml2_idp_metadata, "" > There was some discussion offline and it may be better to keep the old flag ok, and the same for saml2_sp_callback_url http://gerrit.cloudera.org:8080/#/c/23237/11/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/23237/11/be/src/util/webserver.cc@1018 PS11, Line 1018: pStatusC > typo ack -- To view, visit http://gerrit.cloudera.org:8080/23237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12540300529f9c240abf7196141ecb0ae6e37995 Gerrit-Change-Number: 23237 Gerrit-PatchSet: 12 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 17 Jan 2026 22:15:21 +0000 Gerrit-HasComments: Yes
