Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/23237 )
Change subject: IMPALA-14285: Add SAML2 authentication support for Coordinator Web UI ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/23237/12/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/23237/12/be/src/rpc/authentication.cc@979 PS12, Line 979: std::unique_ptr<TWrappedHttpResponse> response_ptr = Ge > optional: Agree with the 1st one, but I would keep the pointer sequence explicit IYDM, since it may get easily confusing. Besides, the 2nd improvement would eliminate the unique_ptr declaration at all http://gerrit.cloudera.org:8080/#/c/23237/11/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/23237/11/be/src/util/webserver.cc@1018 PS11, Line 1018: pStatusC > another typo :) I think your comment is still for the previous changeset. http://gerrit.cloudera.org:8080/#/c/23237/12/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/23237/12/be/src/util/webserver.cc@1035 PS12, Line 1035: } else { : returnWrappedResponse(connection, *response); > Is it possible to get other status codes? I don't see "authenticated" being Java sets only those 2 codes, but we can do the generic 'else' for negative case. http://gerrit.cloudera.org:8080/#/c/23237/12/be/src/util/webserver.cc@1219 PS12, Line 1219: reserve(con > This is not new code, but it seems better to call reserve(content_len) on o Ack -- To view, visit http://gerrit.cloudera.org:8080/23237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12540300529f9c240abf7196141ecb0ae6e37995 Gerrit-Change-Number: 23237 Gerrit-PatchSet: 13 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 21 Jan 2026 16:15:36 +0000 Gerrit-HasComments: Yes
