Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23816 )
Change subject: IMPALA-9935: Support individual partitions in catalog_object webUI page ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/23816/5/be/src/catalog/catalog-util.cc File be/src/catalog/catalog-util.cc: http://gerrit.cloudera.org:8080/#/c/23816/5/be/src/catalog/catalog-util.cc@186 PS5, Line 186: hou > nit: The value string "12/25/2025" is not a URL so saying "it" to represent Done http://gerrit.cloudera.org:8080/#/c/23816/5/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java: http://gerrit.cloudera.org:8080/#/c/23816/5/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@1083 PS5, Line 1083: return partitionDesc; : } : : /** : * Helper method to verify that a partition result matches expected values. : */ : private void verifyPartitionResult(TCatalogObject result, String dbName, : String tableName, String partitionName) { : assertNotNull(result); : assertEquals(TCatalogObjectType.HDFS_PARTITION, result.getType()); : assertTrue(result.isSetHdfs_partition()); : assertEquals(dbName, result.getHdfs_partition().getDb_name()); : assertEquals(tableName, result.getHdfs_partition().getTbl_name()); : assertEquals(partitionName, result.getHdfs_partition().getPartition_name()); : } > Extract these into a method and use it twice in this test. It can also be u Thanks for the clarification. Wrote few small helper functions and refactored the code for getting rid of all duplicate code. http://gerrit.cloudera.org:8080/#/c/23816/5/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@1109 PS5, Line 1109: try { : catalog_.getTCatalogObject(partitionDesc); : > nit: remove simple and verbose comments like this that are already explaine Done http://gerrit.cloudera.org:8080/#/c/23816/5/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@1123 PS5, Line 1123: private void loadAndVerifyPartitionError(String dbName, String tableName, : String partitionName, String expectedErrorMsg) throws CatalogException { : catalog_.getOrLoadTable(dbName, tableName, "test", null); : verifyPartitionError(dbName, tableName, partitionName, expectedErrorMsg); : } : : /** : * Test valid partition retrieval with correct partition keys. : */ : @Test : public void testGetValidPartitions() throws CatalogException { : // Load a partitioned table : HdfsTable table = (HdfsTable) catalog_.getOrLoadTable("functional", "alltypes", : > Can we use testPartitionWithError() here? Done http://gerrit.cloudera.org:8080/#/c/23816/5/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@1146 PS5, Line 1146: // Test 2: Another valid partition (year=2010, month=12) > To refactor more codes, we need a method like this without loading the tabl Done http://gerrit.cloudera.org:8080/#/c/23816/5/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@1148 PS5, Line 1148: "year=2010/month=12"); : result = catalog_.getTCatalogObject(partitionDesc); : verifyPartitionResult(result, "functional", "alltypes", "year=2010/month=12"); : } : : @Test : public void testGetNonExistingPartition() th > There are still duplicated codes like these. Let's extract these to a metho Done -- To view, visit http://gerrit.cloudera.org:8080/23816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5645a20283e664af12d04a9665c8870c7666a74c Gerrit-Change-Number: 23816 Gerrit-PatchSet: 6 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:19:52 +0000 Gerrit-HasComments: Yes
