Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23816 )

Change subject: IMPALA-9935: Support individual partitions in catalog_object 
webUI page
......................................................................


Patch Set 6:

(1 comment)

> Patch Set 6:
>
> Build Failed
>
> https://jenkins.impala.io/job/gerrit-code-review-checks/21428/ : Initial code 
> review checks failed. See linked job for details on the failure.

The build failure is unrelated: 
https://jenkins.impala.io/job/ubuntu-20.04-build-only-ARM/7028/
The job succeeds in retry: 
https://jenkins.impala.io/job/ubuntu-20.04-build-only-ARM/7029/

http://gerrit.cloudera.org:8080/#/c/23816/6/fe/src/main/java/org/apache/impala/catalog/Catalog.java
File fe/src/main/java/org/apache/impala/catalog/Catalog.java:

http://gerrit.cloudera.org:8080/#/c/23816/6/fe/src/main/java/org/apache/impala/catalog/Catalog.java@686
PS6, Line 686:           // Parse partition name (e.g., "year=2010/month=3") 
into partition spec
             :           List<TPartitionKeyValue> partitionSpec =
             :               FeCatalogUtils.parsePartitionName(partitionName, 
hdfsTable);
             :           HdfsPartition partition =
             :               
hdfsTable.getPartitionFromThriftPartitionSpec(partitionSpec);
I just realized HdfsTable has a method to get partitions from the partition 
name strings: getPartitionsForNames(). It leverages the nameToPartitionMap_ so 
it's more efficient than getPartitionFromThriftPartitionSpec() whichs iterate 
all the partitions. Is it something we can use?



--
To view, visit http://gerrit.cloudera.org:8080/23816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5645a20283e664af12d04a9665c8870c7666a74c
Gerrit-Change-Number: 23816
Gerrit-PatchSet: 6
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Mon, 19 Jan 2026 11:05:26 +0000
Gerrit-HasComments: Yes

Reply via email to