Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23666 )
Change subject: WIP: do not review, Test with hopefully 1 jenkins error ...................................................................... Patch Set 58: (24 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@219 PS58, Line 219: newFetch = changedList.get(0); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@227 PS58, Line 227: newOffset= changedList.get(0); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexSimplify.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexSimplify.java: http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexSimplify.java@42 PS58, Line 42: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaRexSimplify.class.getName()); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java: http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java@92 PS58, Line 92: return false; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortSimplifyRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortSimplifyRule.java: http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortSimplifyRule.java@40 PS58, Line 40: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaSortSimplifyRule.class.getName()); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java: http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java@43 PS58, Line 43: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaViewTable.class.getName()); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java@71 PS58, Line 71: ImpalaMQContext converterContext = (ImpalaMQContext) cluster.getPlanner().getContext(); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java: http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@85 PS58, Line 85: protected static final Logger LOG = LoggerFactory.getLogger(CalciteAnalysisDriver.class.getName()); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@364 PS58, Line 364: SqlNode asNode = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java: http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@284 PS58, Line 284: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@317 PS58, Line 317: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@68 PS58, Line 68: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@73 PS58, Line 73: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@75 PS58, Line 75: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@80 PS58, Line 80: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java: http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@175 PS58, Line 175: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@222 PS58, Line 222: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@226 PS58, Line 226: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@317 PS58, Line 317: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@346 PS58, Line 346: SqlNode asNode = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@361 PS58, Line 361: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@369 PS58, Line 369: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/58/tests/query_test/test_chars.py File tests/query_test/test_chars.py: http://gerrit.cloudera.org:8080/#/c/23666/58/tests/query_test/test_chars.py@31 PS58, Line 31: ) flake8: E123 closing bracket does not match indentation of opening bracket's line http://gerrit.cloudera.org:8080/#/c/23666/58/tests/query_test/test_exprs.py File tests/query_test/test_exprs.py: http://gerrit.cloudera.org:8080/#/c/23666/58/tests/query_test/test_exprs.py@73 PS58, Line 73: # flake8: E303 too many blank lines (2) -- To view, visit http://gerrit.cloudera.org:8080/23666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4af2efcf8d8a6038ad67aa7ef5da57d8d0f8a2bc Gerrit-Change-Number: 23666 Gerrit-PatchSet: 58 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 17 Feb 2026 15:09:01 +0000 Gerrit-HasComments: Yes
