Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23666 )
Change subject: WIP: do not review, Test with hopefully 1 jenkins error ...................................................................... Patch Set 68: (31 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@219 PS68, Line 219: newFetch = changedList.get(0); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@227 PS68, Line 227: newOffset= changedList.get(0); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexSimplify.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexSimplify.java: http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexSimplify.java@42 PS68, Line 42: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaRexSimplify.class.getName()); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterProjectTransposeRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterProjectTransposeRule.java: http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterProjectTransposeRule.java@49 PS68, Line 49: super.onMatch(call); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaProjectMergeRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaProjectMergeRule.java: http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaProjectMergeRule.java@49 PS68, Line 49: super.onMatch(call); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java: http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java@92 PS68, Line 92: return false; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortSimplifyRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortSimplifyRule.java: http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortSimplifyRule.java@40 PS68, Line 40: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaSortSimplifyRule.class.getName()); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java: http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java@43 PS68, Line 43: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaViewTable.class.getName()); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java@71 PS68, Line 71: ImpalaMQContext converterContext = (ImpalaMQContext) cluster.getPlanner().getContext(); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java: http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@85 PS68, Line 85: protected static final Logger LOG = LoggerFactory.getLogger(CalciteAnalysisDriver.class.getName()); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@364 PS68, Line 364: SqlNode asNode = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java: http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@284 PS68, Line 284: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@317 PS68, Line 317: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@68 PS68, Line 68: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@73 PS68, Line 73: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@75 PS68, Line 75: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@80 PS68, Line 80: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java: http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@175 PS68, Line 175: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@222 PS68, Line 222: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@226 PS68, Line 226: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@317 PS68, Line 317: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@346 PS68, Line 346: SqlNode asNode = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@361 PS68, Line 361: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@369 PS68, Line 369: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java: http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@434 PS68, Line 434: // XXX: placing in hack for line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@435 PS68, Line 435: // select coalesce('2012-01-01', cast('2012-02-02' as timestamp), cast('2012-02-02' as timestamp)), line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@436 PS68, Line 436: // coalesce('2012-01-01', cast('2012-02-02' as date), cast('2012-02-02' as timestamp)); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@437 PS68, Line 437: // maybe there is a typecompatibility that works properly, but the string literal is seen as line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23666/68/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@448 PS68, Line 448: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23666/68/tests/query_test/test_chars.py File tests/query_test/test_chars.py: http://gerrit.cloudera.org:8080/#/c/23666/68/tests/query_test/test_chars.py@31 PS68, Line 31: ) flake8: E123 closing bracket does not match indentation of opening bracket's line http://gerrit.cloudera.org:8080/#/c/23666/68/tests/query_test/test_exprs.py File tests/query_test/test_exprs.py: http://gerrit.cloudera.org:8080/#/c/23666/68/tests/query_test/test_exprs.py@93 PS68, Line 93: d flake8: E301 expected 1 blank line, found 0 -- To view, visit http://gerrit.cloudera.org:8080/23666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4af2efcf8d8a6038ad67aa7ef5da57d8d0f8a2bc Gerrit-Change-Number: 23666 Gerrit-PatchSet: 68 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 25 Feb 2026 19:55:39 +0000 Gerrit-HasComments: Yes
