Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23982 )
Change subject: IMPALA-14738: Adds basic testing for Iceberg V3 tables ...................................................................... Patch Set 4: (1 comment) LGTM! http://gerrit.cloudera.org:8080/#/c/23982/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/23982/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@265 PS2, Line 265: if (field.initialDefaultLiteral() != null) { > Actually no, this code checks non-materialized SlotRefs as well which is no Done -- To view, visit http://gerrit.cloudera.org:8080/23982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1b90f1af539731d4653e83b848d55517a3acb58 Gerrit-Change-Number: 23982 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 20 Feb 2026 07:09:19 +0000 Gerrit-HasComments: Yes
