Arnab Karmakar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24001 )

Change subject: IMPALA-14737: Push down LIKE predicates to Iceberg
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24001/4/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-predicates.test
File 
testdata/workloads/functional-planner/queries/PlannerTest/iceberg-predicates.test:

http://gerrit.cloudera.org:8080/#/c/24001/4/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-predicates.test@122
PS4, Line 122: select * from iceberg_partitioned where action like "d%" and 
event_time < "2022-01-01" and id < 10
> Done
Ah, I missed this important case!
For patterns like above "d%d", I dont know how startsWith() is going to work, 
as we cant pushdown startsWith("string_col", "d") and simply ignore the suffix 
"d". My understanding now is that we can only pushdown the patterns that dont 
have any literals after the wildcard, otherwise we'll be ignoring the suffix 
thats incorrect.



--
To view, visit http://gerrit.cloudera.org:8080/24001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I548834126540bcc8d22efc872c2571293b8b7ec4
Gerrit-Change-Number: 24001
Gerrit-PatchSet: 5
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 24 Feb 2026 04:08:57 +0000
Gerrit-HasComments: Yes

Reply via email to