Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24001 )
Change subject: IMPALA-14737 Part1: Push down LIKE predicates to Iceberg ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/24001/6/fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java File fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java: http://gerrit.cloudera.org:8080/#/c/24001/6/fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java@169 PS6, Line 169: : /** : * Checks if there's any literal (non-wildcard) content after the given position. : * This determines if a pattern like 'd%d' has content after the first wildcard. : * Only unescaped % and _ are considered non-literal. : * : * @param pattern The pattern string from StringLiteral.getUnescapedValue() : * @param afterPos Position to check after (exclusive) : * @return True if there's any literal content after afterPos : */ : static boolean hasLiteralContentAfterWildcard(String pattern, int afterPos) { : for (int i = afterPos + 1; i < pattern.length(); i++) { : char c = pattern.charAt(i); : > This could be moved to a helper method as it is also used by findFirstUnesc Done http://gerrit.cloudera.org:8080/#/c/24001/4/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-predicates.test File testdata/workloads/functional-planner/queries/PlannerTest/iceberg-predicates.test: http://gerrit.cloudera.org:8080/#/c/24001/4/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-predicates.test@122 PS4, Line 122: select * from iceberg_partitioned where action like "d%" and event_time < "2022-01-01" and id < 10 > In the end, I think we want both: Alright, it makes sense now! Yes, Im also in favour of doing the second part in another patch, it'll keep the review and testing simpler. Added "Part1" in commit message header. http://gerrit.cloudera.org:8080/#/c/24001/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test: http://gerrit.cloudera.org:8080/#/c/24001/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test@330 PS6, Line 330: lts (should only match 'árvíztűrőtükörfúrógép' and not 'á > We might need a new table for this, because iceberg_partitioned only has 'd Done. Checking árvíz%p in table ice_utf8_test returns correct results (should only match 'árvízt?r?tükörfúrógép' and not 'árvízt?r?') -- To view, visit http://gerrit.cloudera.org:8080/24001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I548834126540bcc8d22efc872c2571293b8b7ec4 Gerrit-Change-Number: 24001 Gerrit-PatchSet: 7 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 24 Feb 2026 12:52:39 +0000 Gerrit-HasComments: Yes
