Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/24031 )
Change subject: IMPALA-14429 addendum: Only int types need extra conversion. ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Change looks ok to me but does this not cause any changes in the tests ? For instance looking at the original patch: https://gerrit.cloudera.org/c/23724/12/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q33.test#164 When isExactNumeric() was used, the Decimal precision/scale for some of the constants had changed in the plan. http://gerrit.cloudera.org:8080/#/c/24031/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24031/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-14429 addendum: Only int types need extra conversion. nit: move the word 'addendum' after the ":" based on the convention. -- To view, visit http://gerrit.cloudera.org:8080/24031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic41e0141737c771b6d5ea48aa99144a919427207 Gerrit-Change-Number: 24031 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 25 Feb 2026 07:15:43 +0000 Gerrit-HasComments: Yes
