Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24031 )
Change subject: IMPALA-14429: (addendum) Only int types need extra conversion. ...................................................................... Patch Set 1: (1 comment) Yeah, it's something I should have caught, and you're right, those tests did change back to what they were. The decimal comparison changed and they were no longer matching. For instance, one comparison was casting -6 to (3,0), but the field in the database was (5, 2). So the tests look better now. http://gerrit.cloudera.org:8080/#/c/24031/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24031/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-14429 addendum: Only int types need extra conversion. > nit: move the word 'addendum' after the ":" based on the convention. done -- To view, visit http://gerrit.cloudera.org:8080/24031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic41e0141737c771b6d5ea48aa99144a919427207 Gerrit-Change-Number: 24031 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 25 Feb 2026 13:36:33 +0000 Gerrit-HasComments: Yes
