Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/23963 )
Change subject: IMPALA-14575: Add constant handling for Hive GenericUDFs ...................................................................... Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/23963/12/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/23963/12/common/thrift/Frontend.thrift@71 PS12, Line 71: Hive > nit: Hive UDF executor? Done http://gerrit.cloudera.org:8080/#/c/23963/12/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/23963/12/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java@1 PS12, Line 1: // Licensed to the Apache Software Foundation (ASF) under one > nit: indent Done http://gerrit.cloudera.org:8080/#/c/23963/12/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfInputHandler.java File fe/src/main/java/org/apache/impala/hive/executor/HiveUdfInputHandler.java: http://gerrit.cloudera.org:8080/#/c/23963/12/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfInputHandler.java@26 PS12, Line 26: import org.apache.hadoop.io.Writable; > nit: lot of unused imports Done http://gerrit.cloudera.org:8080/#/c/23963/12/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfInputHandler.java@170 PS12, Line 170: case LONG_WRITABLE: > This is pretty similar to HiveUdfExecutorLegacy.java:77. Could you please e Done http://gerrit.cloudera.org:8080/#/c/23963/12/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfInputHandler.java@226 PS12, Line 226: > We usually don't print out the stacktrace. Done -- To view, visit http://gerrit.cloudera.org:8080/23963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a6ca8c0bab499dffed88bb9786753da559af4c5 Gerrit-Change-Number: 23963 Gerrit-PatchSet: 13 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:30:37 +0000 Gerrit-HasComments: Yes
