Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23963 )
Change subject: IMPALA-14575: Add constant handling for Hive GenericUDFs ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/23963/15/be/src/exprs/expr-value.h File be/src/exprs/expr-value.h: http://gerrit.cloudera.org:8080/#/c/23963/15/be/src/exprs/expr-value.h@211 PS15, Line 211: void* setToAnyVal(impala_udf::AnyVal* v, const ColumnType& type) { nit: capitalization doesn't match the adjacent functions. Seems like pattern here would be SetToAnyVal. http://gerrit.cloudera.org:8080/#/c/23963/15/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/23963/15/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java@170 PS15, Line 170: PrimitiveCategory cat = getPrimitiveCategory(t); Could we move this after the isConst check? http://gerrit.cloudera.org:8080/#/c/23963/15/testdata/workloads/functional-query/queries/QueryTest/java-udf.test File testdata/workloads/functional-query/queries/QueryTest/java-udf.test: http://gerrit.cloudera.org:8080/#/c/23963/15/testdata/workloads/functional-query/queries/QueryTest/java-udf.test@381 PS15, Line 381: select identity(bool_col), identity(tinyint_col), Do we have a test with mixed values somewhere? It'd be nice to double check that's covered. If there is, just mention it under Testing in the commit message. -- To view, visit http://gerrit.cloudera.org:8080/23963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a6ca8c0bab499dffed88bb9786753da559af4c5 Gerrit-Change-Number: 23963 Gerrit-PatchSet: 15 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2026 20:22:17 +0000 Gerrit-HasComments: Yes
