Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23942 )
Change subject: IMPALA-14230: Add catch-up mode for event processing ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/23942/6/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/23942/6/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@956 PS6, Line 956: Set<TableName> tableNames = : tableWriteIds_.stream() : .map(writeId -> new TableName(writeId.getDbName(), writeId.getTblName())) : .collect(Collectors.toSet()); > tableNames_ is currently a Set<String>, and if using it for the invalidate That's a good point. This won't make a big difference in performance, just make the code cleaner. If it makes backporting this patch to older versions harder, I'm OK to defer doing this. -- To view, visit http://gerrit.cloudera.org:8080/23942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib906c06346d5d3159999eeac632e1318bc060065 Gerrit-Change-Number: 23942 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 27 Feb 2026 01:41:45 +0000 Gerrit-HasComments: Yes
