Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23942 )
Change subject: IMPALA-14230: Add catch-up mode for event processing ...................................................................... Patch Set 7: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/23942/6/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/23942/6/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@956 PS6, Line 956: protected Collection<TableName> getTableNames() { : return tableWriteIds_.stream() : .map(writeId -> new TableName(writeId.getDbName(), writeId.getTblName())) : .collect(Collectors.toSet()); > Thanks. I added getTableNames() as suggested. To avoid making backports dif Ack http://gerrit.cloudera.org:8080/#/c/23942/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/23942/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3427 PS6, Line 3427: skipIfInvalidate > Done Ack http://gerrit.cloudera.org:8080/#/c/23942/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/23942/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1087 PS6, Line 1087: infoLog("Catch-up Mode: Skipping event due to event lag of {}s", lag); > Done Ack http://gerrit.cloudera.org:8080/#/c/23942/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/23942/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1089 PS7, Line 1089: if (tables != null) { How would this be null? -- To view, visit http://gerrit.cloudera.org:8080/23942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib906c06346d5d3159999eeac632e1318bc060065 Gerrit-Change-Number: 23942 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2026 17:22:20 +0000 Gerrit-HasComments: Yes
