Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24018 )

Change subject: IMPALA-14768: Add the operation type to the lineage graph
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

LGTM!

http://gerrit.cloudera.org:8080/#/c/24018/4/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java:

http://gerrit.cloudera.org:8080/#/c/24018/4/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@982
PS4, Line 982: stmtClass.equals(CreateViewStmt.class)
instanceof could be better here as it would handle subclasses as well if 
there's any.



--
To view, visit http://gerrit.cloudera.org:8080/24018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb94120a9bb1b994d4e681ea98521035bcc6510e
Gerrit-Change-Number: 24018
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 02 Mar 2026 16:07:25 +0000
Gerrit-HasComments: Yes

Reply via email to