Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/24018 )
Change subject: IMPALA-14768: Add the operation type to the lineage graph ...................................................................... Patch Set 5: Code-Review-1 (4 comments) Thanks for working on this, great addition to the lineage output! However, there's also another lineage.test file, used by PlannerTest. I think that should also include operationType and needs some ground-working as well. http://gerrit.cloudera.org:8080/#/c/24018/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24018/5//COMMIT_MSG@42 PS5, Line 42: - Updated lineage.test to make sure each lineage event comes with its : respective operation type. : We have another lineage.test file at testdata/workloads/functional-planner/queries/PlannerTest/lineage.test, I think it also need to be updated. Moreover, PlannerTestBase's checkColumnLineage https://github.com/apache/impala/blob/79e2ab99/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java#L775 uses ColumnLineageGraph.createFromJSON and ColumnLineageGraph.fromThrift, so those also should be extended to handle operation type. http://gerrit.cloudera.org:8080/#/c/24018/5/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java: http://gerrit.cloudera.org:8080/#/c/24018/5/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@814 PS5, Line 814: public static ColumnLineageGraph fromThrift(TLineageGraph obj) { Add operationType handling. http://gerrit.cloudera.org:8080/#/c/24018/5/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@841 PS5, Line 841: public static ColumnLineageGraph createFromJSON(String json) { Add operationType handling. http://gerrit.cloudera.org:8080/#/c/24018/5/testdata/workloads/functional-planner/queries/PlannerTest/lineage.test File testdata/workloads/functional-planner/queries/PlannerTest/lineage.test: PS5: Here is the other lineage.test, which should also include operationType. -- To view, visit http://gerrit.cloudera.org:8080/24018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb94120a9bb1b994d4e681ea98521035bcc6510e Gerrit-Change-Number: 24018 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2026 14:18:12 +0000 Gerrit-HasComments: Yes
