Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24026 )
Change subject: IMPALA-14776 (part 1): Auto-close manually created impala clients ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/24026/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/24026/3/tests/common/impala_test_suite.py@276 PS3, Line 276: # In case of custom cluster tests t > I think that this should be an instance member, or a class member in Impala I made this an instance member set in setup_method(). http://gerrit.cloudera.org:8080/#/c/24026/3/tests/common/impala_test_suite.py@506 PS3, Line 506: if cls.hs2_http_client: : cls.hs2_http_client.close() > This states that closing is not always idempotent - can this be an issue fo I haven't encountered that issue. -- To view, visit http://gerrit.cloudera.org:8080/24026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib550527838a81cd2aaf69bb715080f6ac6da3786 Gerrit-Change-Number: 24026 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2026 20:27:38 +0000 Gerrit-HasComments: Yes
