Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24026 )
Change subject: IMPALA-14776 (part 1): Auto-close manually created impala clients ...................................................................... Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/24026/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24026/5//COMMIT_MSG@28 PS5, Line 28: This means that : test classes need to call ImpalaTestSuite::setup_method() and : teardown_method(). This modifies several test classes to call : these methods appropriately. I hoped that there will be no need to touch many tests,but generally I think that calling the parent's setup/teardown method is the right thing to do. http://gerrit.cloudera.org:8080/#/c/24026/5/tests/custom_cluster/test_scratch_disk.py File tests/custom_cluster/test_scratch_disk.py: http://gerrit.cloudera.org:8080/#/c/24026/5/tests/custom_cluster/test_scratch_disk.py@97 PS5, Line 97: ImpalaTestSuite Maybe it would be better to have a base class like ManualCustomCluster test that works like a custom cluster test, but skip's its setup_method/teardown_method as the tests are expected to restart the cluster themselves? This looks cleaner at the first glance, but I don't know what could it break. -- To view, visit http://gerrit.cloudera.org:8080/24026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib550527838a81cd2aaf69bb715080f6ac6da3786 Gerrit-Change-Number: 24026 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2026 12:08:34 +0000 Gerrit-HasComments: Yes
