Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24104 )

Change subject: IMPALA-14839: Add counters for slowest channels in 
KrpcDataStreamSenders
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24104/1/be/src/runtime/krpc-data-stream-sender.cc
File be/src/runtime/krpc-data-stream-sender.cc:

http://gerrit.cloudera.org:8080/#/c/24104/1/be/src/runtime/krpc-data-stream-sender.cc@1355
PS1, Line 1355:     
slowest_network_time_stats_->SetStats(*channels_[slowest_network]->GetNetworkTimeStats());
line too long (94 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e56dab3603ea6c5fb345793485af6ed52613046
Gerrit-Change-Number: 24104
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Sat, 14 Mar 2026 07:19:32 +0000
Gerrit-HasComments: Yes

Reply via email to