Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24104
to look at the new patch set (#3).
Change subject: IMPALA-14839: Add counters for slowest channels in
KrpcDataStreamSenders
......................................................................
IMPALA-14839: Add counters for slowest channels in KrpcDataStreamSenders
Example output:
KrpcDataStreamSender (dst_id=2):
Slowest network: csringhofer-7000-ubuntu a248872a6bdec49f:719cedac00000005
Slowest receiver: csringhofer-7000-ubuntu a248872a6bdec49f:719cedac00000005
- NetworkThroughput: (Avg: 51.94 KB/sec ; Min: 51.94 KB/sec ; Max: 51.94
KB/sec ; Number of samples: 1)
- RpcNetworkTime: (Avg: 207.683us ; Min: 74.744us ; Max: 319.649us ; Sum:
830.732us ; Number of samples: 4)
- RpcRecvrTime: (Avg: 68.147us ; Min: 24.277us ; Max: 101.351us ; Sum:
272.591us ; Number of samples: 4)
- Slowest RpcNetworkTime: (Avg: 197.196us ; Min: 74.744us ; Max: 319.649us
; Sum: 394.393us ; Number of samples: 2)
- Slowest RpcRecvrTime: (Avg: 62.814us ; Min: 24.277us ; Max: 101.351us ;
Sum: 125.628us ; Number of samples: 2)
Track recvr/network stat for each channel separately and add the one
with the highest recvr/network sum to the profile. The hostname and
fragment instance id for the selected channel is added as info string.
The new counters are only added if there are >1 channels.
NetworkThroughput is not tracked separately as I consider
it to be less useful.
The channels are selected during the teardown of the sender so they are
not available while the query is still running. Continously updating
the slowest could be done periodically or in TransmitDataCompleteCb
but this would add some complexity.
Testing:
- tested manually
Change-Id: I8e56dab3603ea6c5fb345793485af6ed52613046
---
M be/src/runtime/krpc-data-stream-sender.cc
M be/src/runtime/krpc-data-stream-sender.h
M be/src/util/runtime-profile-counters.h
M be/src/util/runtime-profile.cc
4 files changed, 63 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/24104/3
--
To view, visit http://gerrit.cloudera.org:8080/24104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e56dab3603ea6c5fb345793485af6ed52613046
Gerrit-Change-Number: 24104
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
