Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24097
to look at the new patch set (#4).
Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and
simplify code
......................................................................
IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
IMPALA-14592 introduced the concept of "hidden columns". Kudu's
auto-incrementing columns were already treated as hidden even
before we introduced that concept.
With this patch KuduColumn overrides isHidden() and return true
if column is auto-incrementing. This helped us simplifying the code
at a few places.
Table.getColumnsInHiveOrder() doesn't return hidden columns, which
means it's not necessary to call isHidden() on the returned columns.
Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduModifyImpl.java
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/main/java/org/apache/impala/catalog/FeTable.java
M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
7 files changed, 20 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/24097/4
--
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
