Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )
Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code ...................................................................... Patch Set 4: Seems like auto-incrementing columns are half-hidden only, as they appear in the DESCRIBE output: https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/kudu_describe.test#L139 Removing them would be a breaking change, but it's probably the right thing to do. CREATE TABLE LIKE also clones auto_incrementing_id, but I think it's a bug, even if we have a test for it: https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test#L112 I think the cleanest way to move forward is to remove auto_incrementing_id from the DESCRIBE output and omitting it during CREATE TABLE LIKE. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/24097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9 Gerrit-Change-Number: 24097 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2026 11:53:01 +0000 Gerrit-HasComments: No
