Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10792 )

Change subject: IMPALA-3040: Remove cache directive before dropping a table
......................................................................


Patch Set 2:

> Do you know what in test_caching_ddl() is calling this drop (drop db 
> cascade/drop table etc.) ?
https://github.com/apache/impala/blob/master/tests/query_test/test_hdfs_caching.py#L207
BTW, The specific case I looked into failed in test_caching_ddl_drop_database.

> Also, thinking a bit more about your theory, are you able to reproduce it by 
> adding Thread.sleep() s in the required places?
The tricky part is that reloadTable() calls into HMS to get the table before 
loading partitions and we need to let that one succeed. Plus load() is called 
multiple times and the exact timing becomes unclear. I spent some time on it 
but no luck so far.

The fix in this patch should still work.


--
To view, visit http://gerrit.cloudera.org:8080/10792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7701a499405e961456adea63f3592b43bd69170
Gerrit-Change-Number: 10792
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Jun 2018 02:14:00 +0000
Gerrit-HasComments: No

Reply via email to