Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 )
Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services ...................................................................... Patch Set 1: Thanks for taking a look. Answers to your questions: 1. This is slated for Impala 3.1. We will just have to deal with problem in KRPC as it comes. I believe the biggest risk is the Kudu Kerberos implementation. We should have better test coverage for that area. It's burdensome and potentially error prone to have two implementations of the RPC handlers so at some point, we just bite the bullet and make the switch. 2. Yes, we should rename them but I refrain from doing so in this patch to make it easier to review. The renaming can be done in a follow-on patch as it's mostly mechanical. 3. Mostly mechanical. The only challenge may be removing Thrift-only tests which may benefit from some more scrutiny during review. -- To view, visit http://gerrit.cloudera.org:8080/10835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3 Gerrit-Change-Number: 10835 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Jun 2018 20:45:21 +0000 Gerrit-HasComments: No
