Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 )
Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/10835/1/be/src/runtime/data-stream-test.cc File be/src/runtime/data-stream-test.cc: http://gerrit.cloudera.org:8080/#/c/10835/1/be/src/runtime/data-stream-test.cc@23 PS1, Line 23: #include "common/status.h" > I think I've found all the dead code in this patch, but if you want a refer Thanks for checking. http://gerrit.cloudera.org:8080/#/c/10835/1/be/src/runtime/data-stream-test.cc@128 PS1, Line 128: class DataStreamTest : public testing::Test { : protected: : DataStreamTest() : next_val_(0) { : // Stop tests that rely on mismatched sender / receiver pairs timing out from failing. : > No longer needed. Done http://gerrit.cloudera.org:8080/#/c/10835/1/be/src/runtime/data-stream-test.cc@134 PS1, Line 134: ~DataStreamTest() { runtime_state_->ReleaseResources(); } : : virtual void SetUp() { : > No longer needed. Done http://gerrit.cloudera.org:8080/#/c/10835/1/be/src/runtime/data-stream-test.cc@139 PS1, Line 139: erPool(32 * 1024, 1024 * 1024 * 1024, 32 * 1024); > You can replace this with: Done http://gerrit.cloudera.org:8080/#/c/10835/1/tests/custom_cluster/test_rpc_exception.py File tests/custom_cluster/test_rpc_exception.py: http://gerrit.cloudera.org:8080/#/c/10835/1/tests/custom_cluster/test_rpc_exception.py@a73 PS1, Line 73: > Can't this happen without TransmitData() today? Don't we also call it on R ReportExecStatus() can be very timing sensitive as the number of iterations it's invoked depends on how long the query runs for. -- To view, visit http://gerrit.cloudera.org:8080/10835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3 Gerrit-Change-Number: 10835 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Wed, 11 Jul 2018 22:02:48 +0000 Gerrit-HasComments: Yes
