Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 )
Change subject: IMPALA-1760: Implement shutdown command ...................................................................... Patch Set 7: (6 comments) Fixed a few minor things in the test code that I noticed when doing another pass over it. http://gerrit.cloudera.org:8080/#/c/10744/7/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/10744/7/common/thrift/Frontend.thrift@610 PS7, Line 610: 13: optional TAdminRequest admin_request > nit: 13 should be after 12: (L618) I was thinking that it made sense to group the requests together rather than listing things chronologically here, but I missed that there wasn't any logical grouping already. http://gerrit.cloudera.org:8080/#/c/10744/6/common/thrift/Types.thrift File common/thrift/Types.thrift: http://gerrit.cloudera.org:8080/#/c/10744/6/common/thrift/Types.thrift@104 PS6, Line 104: ADMIN_FN // Admin comment, e.g. ": shutdown()". Typo http://gerrit.cloudera.org:8080/#/c/10744/7/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: http://gerrit.cloudera.org:8080/#/c/10744/7/common/thrift/generate_error_codes.py@367 PS7, Line 367: > nit: empty line Done http://gerrit.cloudera.org:8080/#/c/10744/7/fe/src/main/java/org/apache/impala/analysis/AdminFnStmt.java File fe/src/main/java/org/apache/impala/analysis/AdminFnStmt.java: http://gerrit.cloudera.org:8080/#/c/10744/7/fe/src/main/java/org/apache/impala/analysis/AdminFnStmt.java@104 PS7, Line 104: > nit: indentation Done http://gerrit.cloudera.org:8080/#/c/10744/7/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/10744/7/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2075 PS7, Line 2075: .error(accessError("server")) : .error(accessError("server"), onServer(TPrivilegeLevel.REFRESH)) : .error(accessError("server"), onServer(TPrivilegeLevel.SELECT)) : .error(accessError("server"), onDatabase("functional", TPrivilegeLevel.ALL)) : .error(accessError("server"), : onTable("functional", "alltypes", TPrivilegeLevel.ALL)); > These errors can be simplified to .error(accessError("server"), allExcept(T That's much nicer! http://gerrit.cloudera.org:8080/#/c/10744/7/www/root.tmpl File www/root.tmpl: http://gerrit.cloudera.org:8080/#/c/10744/7/www/root.tmpl@30 PS7, Line 30: > nit: whitespace Done -- To view, visit http://gerrit.cloudera.org:8080/10744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d5606ccfec84db4482c1e7f0f198103aad141a0 Gerrit-Change-Number: 10744 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 02 Jul 2018 19:04:41 +0000 Gerrit-HasComments: Yes
